Skip to content

chore: use GitHub app token #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2021
Merged

chore: use GitHub app token #175

merged 1 commit into from
Apr 6, 2021

Conversation

erezrokah
Copy link
Contributor

So release-please PRs trigger GitHub workflows.

I'm not using https://github.com/tibdex/github-app-token since it's very hard to know what's the action is doing since the code is complied from TypeScript. I feel it's safer to pin to a commit hash of navikt/github-app-token-generator

@erezrokah erezrokah requested a review from ehmicky April 6, 2021 09:57
@erezrokah erezrokah enabled auto-merge (squash) April 6, 2021 10:04
@erezrokah erezrokah merged commit f3e71f5 into master Apr 6, 2021
JGAntunes
JGAntunes approved these changes Apr 6, 2021
View reviewed changes
Copy link

@JGAntunes JGAntunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 🚀

@erezrokah erezrokah deleted the chore/switch_to_github_app branch April 6, 2021 10:46
@erezrokah
Copy link
Contributor Author

Forgot to add the repo to the list of repos that have access to the secrets and also to install it for the repo.
Should work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JGAntunes JGAntunes JGAntunes approved these changes

@ehmicky ehmicky Awaiting requested review from ehmicky

Assignees
No one assigned
Labels
type: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erezrokah @JGAntunes